-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publishing workflow to GH Actions #86
Conversation
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 18 18
Lines 860 860
=======================================
Hits 619 619
Misses 241 241 Continue to review full report at Codecov.
|
Any thoughts why the |
7138678
to
4a93a44
Compare
I suppose there is no subset of tests working without a backend, since the core package cannot even be imported? |
Yes can we just make the publish job be contingent on the main test matrix passing instead? |
Oh; got the Nonetheless having one job being contingent on another would in fact be useful (like for the minimal/extended test configurations), but I haven't found anything on how to do this so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks! I'll send a message later showing how to have dependent jobs
I'll merge this for now, we can do the dependent stuff later |
Description
Follow-up to #82 adding a publish_pure_python job.